[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240523-9c0425e6b3c697abc1009123@orel>
Date: Thu, 23 May 2024 11:06:03 +0200
From: Andrew Jones <ajones@...tanamicro.com>
To: zhouquan@...as.ac.cn
Cc: anup@...infault.org, atishp@...shpatra.org, paul.walmsley@...ive.com,
palmer@...belt.com, aou@...s.berkeley.edu, kvm@...r.kernel.org,
kvm-riscv@...ts.infradead.org, linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RISC-V: KVM: Fix incorrect reg_subtype labels in
kvm_riscv_vcpu_set_reg_isa_ext function
On Thu, May 23, 2024 at 10:13:34AM GMT, zhouquan@...as.ac.cn wrote:
> From: Quan Zhou <zhouquan@...as.ac.cn>
>
> In the function kvm_riscv_vcpu_set_reg_isa_ext, the original code
> used incorrect reg_subtype labels KVM_REG_RISCV_SBI_MULTI_EN/DIS.
> These have been corrected to KVM_REG_RISCV_ISA_MULTI_EN/DIS respectively.
> Although they are numerically equivalent, the actual processing
> will not result in errors, but it may lead to ambiguous code semantics.
>
> Signed-off-by: Quan Zhou <zhouquan@...as.ac.cn>
> ---
> arch/riscv/kvm/vcpu_onereg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c
> index c676275ea0a0..62874fbca29f 100644
> --- a/arch/riscv/kvm/vcpu_onereg.c
> +++ b/arch/riscv/kvm/vcpu_onereg.c
> @@ -724,9 +724,9 @@ static int kvm_riscv_vcpu_set_reg_isa_ext(struct kvm_vcpu *vcpu,
> switch (reg_subtype) {
> case KVM_REG_RISCV_ISA_SINGLE:
> return riscv_vcpu_set_isa_ext_single(vcpu, reg_num, reg_val);
> - case KVM_REG_RISCV_SBI_MULTI_EN:
> + case KVM_REG_RISCV_ISA_MULTI_EN:
> return riscv_vcpu_set_isa_ext_multi(vcpu, reg_num, reg_val, true);
> - case KVM_REG_RISCV_SBI_MULTI_DIS:
> + case KVM_REG_RISCV_ISA_MULTI_DIS:
> return riscv_vcpu_set_isa_ext_multi(vcpu, reg_num, reg_val, false);
> default:
> return -ENOENT;
>
> base-commit: 29c73fc794c83505066ee6db893b2a83ac5fac63
> --
> 2.34.1
>
>
Reviewed-by: Andrew Jones <ajones@...tanamicro.com>
Powered by blists - more mailing lists