linux-kernel - Re: [PATCH RFT 0/7] arm64: qcom: allow up to 4 lanes for the Type-C DisplayPort Altmode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 23 May 2024 11:06:38 +0200
From: neil.armstrong@...aro.org
To: Luca Weiss <luca.weiss@...rphone.com>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I
 <kishon@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Abhinav Kumar
 <quic_abhinavk@...cinc.com>, linux-arm-msm@...r.kernel.org,
 linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFT 0/7] arm64: qcom: allow up to 4 lanes for the Type-C
 DisplayPort Altmode

Hi Lucas,

On 10/05/2024 08:51, Luca Weiss wrote:
> On Tue Apr 23, 2024 at 4:08 PM CEST,  wrote:
>> On 23/04/2024 15:03, Konrad Dybcio wrote:
>>>
>>>
>>> On 4/5/24 12:19, Luca Weiss wrote:

<snip>

> 
> Next, with DP 4 lane (not working on mainline but still plugged into a
> screen) the diff is quite a bit bigger.
> 
> See attachments for the full files:
> * usb_1_qmpphy_20240503_151052_android_4lane.txt
> * usb_1_qmpphy_20240503_122443_mainline_4lane.txt
> 
> Not attaching the diff because it's quite a lot
> $ diff --ignore-case -U0 usb_1_qmpphy_20240503_151052_android_4lane.txt usb_1_qmpphy_20240503_122443_mainline_4lane.txt
> 
> Not sure this is helpful to anyone, but at least wanted to share what
> I've done so far here.

Thanks a lot for the traces, it founds out the QPHY_V3_DP_COM_PHY_MODE_CTRL stays at 0x3,
which means the mode doesn't get broadcasted to the phy because.... the retimer only broadcasts
the orientation and not the mode... and it works on the HDKs and the X13s because they don't have retimers.

So I made the changes in nb7vpq904m and ptn36502 drivers to get the next mux and broadcast the typec mode,
if you find time could you test it ?

Bjorn could you also test on the rb3gen2 ?

The changes:
https://git.codelinaro.org/neil.armstrong/linux/-/commit/a61fb3b816ecbe28a12480367d9e09b700ec09e1
https://git.codelinaro.org/neil.armstrong/linux/-/commit/f6f976ff692bad430cd945f02b835e355f19632b

Thanks,
Neil

> 
> Regards
> Luca
> 
>>
>> Neil
>>
>>>
>>> Konrad
> 
>