linux-kernel - Re: [v2 1/2] dt-bindings: hwmon: Add mps mp2891 driver bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab6974a8-b345-4f9f-b051-0ae23a860a35@kernel.org>
Date: Thu, 23 May 2024 11:53:36 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Noah Wang <noahwang.wang@...look.com>, linux@...ck-us.net,
 jdelvare@...e.com
Cc: robh@...nel.org, conor+dt@...nel.org, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [v2 1/2] dt-bindings: hwmon: Add mps mp2891 driver bindings

On 23/05/2024 11:33, Noah Wang wrote:
> Add a device tree bindings for mp2891 device.
> 
> Signed-off-by: Noah Wang <noahwang.wang@...look.com>

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Subject: drop driver and describe hardware

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

> ---
>  .../bindings/hwmon/pmbus/mps,mp2891.yaml      | 43 +++++++++++++++++++
>  MAINTAINERS                                   |  8 ++++
>  2 files changed, 51 insertions(+)

..

>  
> +MPS MP2891 DRIVER
> +M:	Noah Wang <noahwang.wang@...look.com>
> +L:	linux-hwmon@...r.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/hwmon/mps,mp2891.yaml
> +F:	Documentation/hwmon/mp2891.rst

There is no such file.

> +F:	drivers/hwmon/pmbus/mp2891.c

There is no such file.

Are you sure your patchset is fully bisectable (including paths here)?

Best regards,
Krzysztof