linux-kernel - Re: [syzbot] [serial?] possible deadlock in uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 23 May 2024 19:30:57 +0800
From: Hillf Danton <hdanton@...a.com>
To: syzbot <syzbot+57cc2f20a84cb4346354@...kaller.appspotmail.com>
Cc: linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [serial?] possible deadlock in uart_write (2)

On Wed, 22 May 2024 23:23:26 -0700
> syzbot has found a reproducer for the following issue on:
> 
> HEAD commit:    de7e71ef8bed mm: simplify and improve print_vma_addr() out..
> git tree:       upstream
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=140480ec980000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git  de7e71ef8bed

--- x/drivers/tty/serial/serial_core.c
+++ y/drivers/tty/serial/serial_core.c
@@ -622,8 +622,9 @@ static ssize_t uart_write(struct tty_str
 		return -EL3HLT;
 
 	port = uart_port_lock(state, flags);
-	if (WARN_ON_ONCE(!state->port.xmit_buf)) {
+	if (!state->port.xmit_buf) {
 		uart_port_unlock(port, flags);
+		WARN_ON_ONCE(1);
 		return 0;
 	}
 
--