linux-kernel - Re: [PATCH] 9p: add missing locking around taking dentry fid list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 23 May 2024 20:38:28 +0900
From: Dominique Martinet <asmadeus@...ewreck.org>
To: Christian Schoenebeck <linux_oss@...debyte.com>
Cc: Eric Van Hensbergen <ericvh@...nel.org>,
	Latchesar Ionkov <lucho@...kov.net>, Greg Kurz <groug@...d.org>,
	Jianyong Wu <jianyong.wu@....com>, stable@...r.kernel.org,
	Eric Van Hensbergen <ericvh@...il.com>, v9fs@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 9p: add missing locking around taking dentry fid list

Christian Schoenebeck wrote on Thu, May 23, 2024 at 12:05:44PM +0200:
> > I really think it's safe, but I do agree that it's hard to read, happy
> > to move the `h = &dentry->d_fsdata` inside the lock if you prefer -- it
> > compiles to the same code for me (x86_64/gcc 13.2.0)
> 
> No need, you can add my RB. Thanks for the clarification!
> 
> Reviewed-by: Christian Schoenebeck <linux_oss@...debyte.com>

Thanks!
I've fixed the typo in the commit message and queued it up in -next,
will send this patch and the trace uninit fix to Linus early next week.

-- 
Dominique Martinet | Asmadeus