linux-kernel - RE: [EXT] Re: [PATCH v2 2/5] dt-bindings: arm: fsl: add imx-se-fw binding doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 23 May 2024 12:30:59 +0000
From: Pankaj Gupta <pankaj.gupta@....com>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, Jonathan Corbet
	<corbet@....net>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, Shawn Guo <shawnguo@...nel.org>,
	Fabio Estevam <festevam@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Pengutronix Kernel Team
	<kernel@...gutronix.de>
Subject: RE: [EXT] Re: [PATCH v2 2/5] dt-bindings: arm: fsl: add imx-se-fw
 binding doc



> -----Original Message-----
> From: Rob Herring (Arm) <robh@...nel.org>
> Sent: Thursday, May 23, 2024 5:55 PM
> To: Pankaj Gupta <pankaj.gupta@....com>
> Cc: linux-doc@...r.kernel.org; Jonathan Corbet <corbet@....net>; Krzysztof
> Kozlowski <krzk+dt@...nel.org>; imx@...ts.linux.dev; Shawn Guo
> <shawnguo@...nel.org>; Fabio Estevam <festevam@...il.com>; linux-
> kernel@...r.kernel.org; Sascha Hauer <s.hauer@...gutronix.de>; linux-arm-
> kernel@...ts.infradead.org; devicetree@...r.kernel.org; Rob Herring
> <robh+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@...aro.org>; Pengutronix Kernel Team
> <kernel@...gutronix.de>
> Subject: [EXT] Re: [PATCH v2 2/5] dt-bindings: arm: fsl: add imx-se-fw binding
> doc
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Thu, 23 May 2024 16:19:33 +0530, Pankaj Gupta wrote:
> > The NXP security hardware IP(s) like: i.MX EdgeLock Enclave, V2X etc.,
> > creates an embedded secure enclave within the SoC boundary to enable
> > features like:
> > - HSM
> > - SHE
> > - V2X
> >
> > Secure-Enclave(s) communication interface are typically via message
> > unit, i.e., based on mailbox linux kernel driver. This driver enables
> > communication ensuring well defined message sequence protocol between
> > Application Core and enclave's firmware.
> >
> > Driver configures multiple misc-device on the MU, for multiple
> > user-space applications, to be able to communicate over single MU.
> >
> > It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.
> >
> > Signed-off-by: Pankaj Gupta <pankaj.gupta@....com>
> > ---
> >  .../devicetree/bindings/firmware/fsl,imx-se.yaml   | 154
> +++++++++++++++++++++
> >  1 file changed, 154 insertions(+)
> >
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/firmware/fsl,imx-se.example.dtb:
> /example-2/firmware/v2x-if@0: failed to match any schema with compatible:
> ['fsl,imx95-v2x']
> Documentation/devicetree/bindings/firmware/fsl,imx-se.example.dtb:
> /example-2/firmware/v2x-if@1: failed to match any schema with compatible:
> ['fsl,imx95-v2x']
> Documentation/devicetree/bindings/firmware/fsl,imx-se.example.dtb:
> /example-2/firmware/v2x-if@2: failed to match any schema with compatible:
> ['fsl,imx95-v2x']
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw
> ork.ozlabs.org%2Fproject%2Fdevicetree-bindings%2Fpatch%2F20240523-
> imx-se-if-v2-2-
> 5a6fd189a539%40nxp.com&data=05%7C02%7Cpankaj.gupta%40nxp.com%7
> C102225d4215b49f9e1e308dc7b2370cd%7C686ea1d3bc2b4c6fa92cd99c5c3
> 01635%7C0%7C0%7C638520639343681926%7CUnknown%7CTWFpbGZsb3d
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%
> 3D%7C0%7C%7C%7C&sdata=BO%2FhtixA%2ByKfjN2UZdas2VzEj9Aoq1I%2F%
> 2FH7m5pLAqPc%3D&reserved=0
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade

I have updated this. But still not able to see the above error.

But, I know why it coming. Following change will fix it.

In the compatible properties:
+  compatible:
+    enum:
+      - fsl,imx8ulp-ele
+      - fsl,imx93-ele
-      - fsl,imx95-ele
+      - fsl,imx95-v2x


Will correct in v3.
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your
> schema.