linux-kernel - Re: [PATCH v2] KEYS: trusted: Use ASN.1 encoded OID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <575953.1716471389@warthog.procyon.org.uk>
Date: Thu, 23 May 2024 14:36:29 +0100
From: David Howells <dhowells@...hat.com>
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: dhowells@...hat.com, linux-integrity@...r.kernel.org,
    keyrings@...r.kernel.org, David Woodhouse <dwmw2@...radead.org>,
    Eric Biggers <ebiggers@...nel.org>,
    James Bottomley <James.Bottomley@...senpartnership.com>,
    Herbert Xu <herbert@...dor.apana.org.au>,
    "David S. Miller" <davem@...emloft.net>,
    Andrew Morton <akpm@...ux-foundation.org>,
    Mimi Zohar <zohar@...ux.ibm.com>, Paul Moore <paul@...l-moore.com>,
    James Morris <jmorris@...ei.org>,
    "Serge E. Hallyn" <serge@...lyn.com>,
    linux-crypto@...r.kernel.org (open list:CRYPTO
                         API),
    linux-kernel@...r.kernel.org (open list),
    linux-security-module@...r.kernel.org (open
                         list:SECURITY SUBSYSTEM)
Subject: Re: [PATCH v2] KEYS: trusted: Use ASN.1 encoded OID

Jarkko Sakkinen <jarkko@...nel.org> wrote:

> There's no reason to encode OID_TPMSealedData at run-time, as it never
> changes.
> 
> Replace it with the encoded version, which has exactly the same size:
> 
> 	67 81 05 0A 01 05
> 
> Include OBJECT IDENTIFIER (0x06) tag and length as the epilogue so that
> the OID can be simply copied to the blob.

This seems reasonable.  We have a limited set of OIDs we can generate
(currently 1).  Better to store the BER-encoded form and copy that in rather
than trying to turn a pretty-printed OID into the BER encoding unless we
absolutely have to.

David