linux-kernel - Re: [PATCH v2] KEYS: trusted: Use ASN.1 encoded OID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D1H2U8D0NDDC.20TI6BZ9BEFQY@kernel.org>
Date: Thu, 23 May 2024 17:00:38 +0300
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "David Howells" <dhowells@...hat.com>
Cc: <linux-integrity@...r.kernel.org>, <keyrings@...r.kernel.org>, "David
 Woodhouse" <dwmw2@...radead.org>, "Eric Biggers" <ebiggers@...nel.org>,
 "James Bottomley" <James.Bottomley@...senpartnership.com>, "Herbert Xu"
 <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>,
 "Andrew Morton" <akpm@...ux-foundation.org>, "Mimi Zohar"
 <zohar@...ux.ibm.com>, "Paul Moore" <paul@...l-moore.com>, "James Morris"
 <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, "open
 list:CRYPTO API" <linux-crypto@...r.kernel.org>, "open list"
 <linux-kernel@...r.kernel.org>, "open list:SECURITY SUBSYSTEM"
 <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH v2] KEYS: trusted: Use ASN.1 encoded OID

On Thu May 23, 2024 at 4:36 PM EEST, David Howells wrote:
> Jarkko Sakkinen <jarkko@...nel.org> wrote:
>
> > There's no reason to encode OID_TPMSealedData at run-time, as it never
> > changes.
> > 
> > Replace it with the encoded version, which has exactly the same size:
> > 
> > 	67 81 05 0A 01 05
> > 
> > Include OBJECT IDENTIFIER (0x06) tag and length as the epilogue so that
> > the OID can be simply copied to the blob.
>
> This seems reasonable.  We have a limited set of OIDs we can generate
> (currently 1).  Better to store the BER-encoded form and copy that in rather
> than trying to turn a pretty-printed OID into the BER encoding unless we
> absolutely have to.

Yup, I crafted a plan in response to James about possibility to generate
all from a CSV file (oid_registry.gen.[sh] and oid_registry.h incldues
oid_registry.gen.h for compat). 

No bandwidth to work in it, but happy to review it.

>
> David

BR, Jarkko