linux-kernel - Re: [PATCH 1/2] dt-bindings: arm: fsl: rename gw7905 to gw75xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240523-vividly-sequester-d85ac7bccbbd@spud>
Date: Thu, 23 May 2024 15:47:44 +0100
From: Conor Dooley <conor@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Tim Harvey <tharvey@...eworks.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, Li Yang <leoyang.li@....com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: fsl: rename gw7905 to gw75xx

On Thu, May 23, 2024 at 09:02:46AM +0200, Krzysztof Kozlowski wrote:
> On 22/05/2024 23:50, Tim Harvey wrote:
> > The GW7905 was renamed to GW7500 before production release.
> > 
> > Signed-off-by: Tim Harvey <tharvey@...eworks.com>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 0027201e19f8..d8bc295079e3 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -920,8 +920,8 @@ properties:
> >                - fsl,imx8mm-ddr4-evk       # i.MX8MM DDR4 EVK Board
> >                - fsl,imx8mm-evk            # i.MX8MM EVK Board
> >                - fsl,imx8mm-evkb           # i.MX8MM EVKB Board
> > +              - gateworks,imx8mm-gw75xx-0x # i.MX8MM Gateworks Board
> 
> That's not even equivalent. You 7500 != 75xx.
> 

> >                - gateworks,imx8mm-gw7904
> > -              - gateworks,imx8mm-gw7905-0x # i.MX8MM Gateworks Board
> 
> Compatibles do not change. It's just a string. Fixed string.

I think there's justification here for removing it, per the commit
message, the rename happened before the device was available to
customers.
Additionally, I think we can give people that upstream things before they're
publicly available a bit of slack, otherwise we're just discouraging
people from upstreaming early.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)