linux-kernel - RE: [RFC PATCH v2 3/8] ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB608387C960ECC119B2DF7101FCF42@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Thu, 23 May 2024 16:02:45 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>, Zaid Alali
	<zaidal@...amperecomputing.com>
CC: "rafael@...nel.org" <rafael@...nel.org>, "lenb@...nel.org"
	<lenb@...nel.org>, "james.morse@....com" <james.morse@....com>,
	"bp@...en8.de" <bp@...en8.de>, "Moore, Robert" <robert.moore@...el.com>,
	"Benjamin.Cheatham@....com" <Benjamin.Cheatham@....com>, "Williams, Dan J"
	<dan.j.williams@...el.com>, "arnd@...db.de" <arnd@...db.de>,
	"Avadhut.Naik@....com" <Avadhut.Naik@....com>,
	"u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
	"john.allen@....com" <john.allen@....com>, "linux-acpi@...r.kernel.org"
	<linux-acpi@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "acpica-devel@...ts.linux.dev"
	<acpica-devel@...ts.linux.dev>
Subject: RE: [RFC PATCH v2 3/8] ACPI: APEI: EINJ: Remove redundant calls to
 einj_get_available_error_type

>> A single call to einj_get_available_error_type in init function is
>> sufficient to save the return value in a global variable to be used
>> later in various places in the code. This commit does not introduce
>> any functional changes, but only removing unnecessary redundant
>> function calls.
>> 
>> Signed-off-by: Zaid Alali <zaidal@...amperecomputing.com>
>
> Seems reasonable to me.
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

Agreed. I've thought about making this change many times, but always
distracted by other issues. Thanks for doing this.

Acked-by: Tony Luck <tony.luck@...el.com>

-Tony