linux-kernel - RE: [EXTERNAL] [PATCH net] net: micrel: Fix lan8841_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <SJ0PR18MB52169D42D6D26244E003BCC8DBF42@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date: Thu, 23 May 2024 16:35:51 +0000
From: Suman Ghosh <sumang@...vell.com>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>,
        "andrew@...n.ch"
	<andrew@...n.ch>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] [PATCH net] net: micrel: Fix lan8841_config_intr after
 getting out of sleep mode

> 	if (phydev->interrupts == PHY_INTERRUPT_ENABLED) {
> 		err = phy_read(phydev, LAN8814_INTS);
>-		if (err)
>+		if (err < 0)
[Suman] Hi Horatiu,
Should we modify this check for phy_write() as well?
> 			return err;
>
> 		/* Enable / disable interrupts. It is OK to enable PTP
>interrupt
>--
>2.34.1
>