linux-kernel - Re: [PATCH v2 2/8] dt-bindings: counter: Add new ti,am62-eqep compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57e4f7b1-2955-4dd5-b9d9-f3b1f27aab75@ti.com>
Date: Fri, 24 May 2024 16:30:32 -0500
From: Judith Mendez <jm@...com>
To: Conor Dooley <conor@...nel.org>
CC: Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        William Breathitt Gray <william.gray@...aro.org>,
        David Lechner
	<david@...hnology.com>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-iio@...r.kernel.org>,
        Nishanth Menon <nm@...com>, Vignesh Raghavendra
	<vigneshr@...com>
Subject: Re: [PATCH v2 2/8] dt-bindings: counter: Add new ti,am62-eqep
 compatible

On 5/24/24 1:38 PM, Conor Dooley wrote:
> On Thu, May 23, 2024 at 06:15:10PM -0500, Judith Mendez wrote:
>> Add new compatible ti,am62-eqep for TI K3 devices. If a device
>> uses this compatible, require power-domains property.
>>
>> Since there is only one functional and interface clock for eqep,
>> clock-names is not really required. The clock-name also changed
>> for TI K3 SoCs so make clock-names optional for the new compatible
>> since there is only one clock that is routed to the IP.
> 
> Really the clock should be named after the function it has in the IP
> block - it looks like "sysoutclk" is more likely the name of the clock
> routed to the IP rather than the role it has?

It is the name of the clock, though id like to keep sysclkout for
backwards compatibility, even though the name is confusing.
~ Judith


>>
>> While we are here, add an example using ti,am62-eqep compatible.
>>
>> Signed-off-by: Judith Mendez <jm@...com>
>> ---
>> Changes since v1:
>> - Fix eqep binding for new compatible, require
>>   power-domains for new compatible
>> ---
>>   .../devicetree/bindings/counter/ti-eqep.yaml  | 53 +++++++++++++++++--
>>   1 file changed, 48 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/counter/ti-eqep.yaml b/Documentation/devicetree/bindings/counter/ti-eqep.yaml
>> index 85f1ff83afe72..c4bb0231f166a 100644
>> --- a/Documentation/devicetree/bindings/counter/ti-eqep.yaml
>> +++ b/Documentation/devicetree/bindings/counter/ti-eqep.yaml
>> @@ -11,7 +11,9 @@ maintainers:
>>   
>>   properties:
>>     compatible:
>> -    const: ti,am3352-eqep
>> +    enum:
>> +      - ti,am3352-eqep
>> +      - ti,am62-eqep
> 
> I'm going to ack this even though the driver makes it seem like the
> devices are compatible (there's no match data etc) given the addition of
> the power domain and changes in required properties.
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> Cheers,
> Conor.
>