linux-kernel - RE: [PATCH] riscv, bpf: Introduce shift add helper with Zba optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM8PR11MB5751217E922FE7CC4D58646CB8F52@DM8PR11MB5751.namprd11.prod.outlook.com>
Date: Fri, 24 May 2024 02:29:43 +0000
From: "Wang, Xiao W" <xiao.w.wang@...el.com>
To: Björn Töpel <bjorn@...nel.org>,
	"paul.walmsley@...ive.com" <paul.walmsley@...ive.com>, "palmer@...belt.com"
	<palmer@...belt.com>, "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
	"luke.r.nels@...il.com" <luke.r.nels@...il.com>, "xi.wang@...il.com"
	<xi.wang@...il.com>
CC: "ast@...nel.org" <ast@...nel.org>, "daniel@...earbox.net"
	<daniel@...earbox.net>, "andrii@...nel.org" <andrii@...nel.org>,
	"martin.lau@...ux.dev" <martin.lau@...ux.dev>, "eddyz87@...il.com"
	<eddyz87@...il.com>, "song@...nel.org" <song@...nel.org>,
	"yonghong.song@...ux.dev" <yonghong.song@...ux.dev>,
	"john.fastabend@...il.com" <john.fastabend@...il.com>, "kpsingh@...nel.org"
	<kpsingh@...nel.org>, "sdf@...gle.com" <sdf@...gle.com>, "haoluo@...gle.com"
	<haoluo@...gle.com>, "jolsa@...nel.org" <jolsa@...nel.org>,
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>, "pulehui@...wei.com"
	<pulehui@...wei.com>, "Li, Haicheng" <haicheng.li@...el.com>
Subject: RE: [PATCH] riscv, bpf: Introduce shift add helper with Zba
 optimization



> -----Original Message-----
> From: Björn Töpel <bjorn@...nel.org>
> Sent: Wednesday, May 22, 2024 12:40 AM
> To: Wang, Xiao W <xiao.w.wang@...el.com>; paul.walmsley@...ive.com;
> palmer@...belt.com; aou@...s.berkeley.edu; luke.r.nels@...il.com;
> xi.wang@...il.com
> Cc: ast@...nel.org; daniel@...earbox.net; andrii@...nel.org;
> martin.lau@...ux.dev; eddyz87@...il.com; song@...nel.org;
> yonghong.song@...ux.dev; john.fastabend@...il.com; kpsingh@...nel.org;
> sdf@...gle.com; haoluo@...gle.com; jolsa@...nel.org; linux-
> riscv@...ts.infradead.org; linux-kernel@...r.kernel.org; bpf@...r.kernel.org;
> pulehui@...wei.com; Li, Haicheng <haicheng.li@...el.com>; Wang, Xiao W
> <xiao.w.wang@...el.com>
> Subject: Re: [PATCH] riscv, bpf: Introduce shift add helper with Zba
> optimization
> 
> Xiao Wang <xiao.w.wang@...el.com> writes:
> 
> > Zba extension is very useful for generating addresses that index into array
> > of basic data types. This patch introduces sh2add and sh3add helpers for
> > RV32 and RV64 respectively, to accelerate pointer array addressing.
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@...el.com>
> 
> This is dependent on [1], and given it hasn't been accepted yet, I'd
> make this patch part of that series.

I would make a new version, combining them as a series. Meanwhile
this patch needs rebase on top of bpf-next and enable one more sh3add
use cases.

BRs,
Xiao

> 
> 
> Björn
> 
> [1] https://lore.kernel.org/linux-riscv/20240516090430.493122-1-
> xiao.w.wang@...el.com/