linux-kernel - RE: [PATCH v5 3/3] scsi: ufs: sysfs: Make max_number_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR04MB6575A38D05EC447D5E043787FCF52@DM6PR04MB6575.namprd04.prod.outlook.com>
Date: Fri, 24 May 2024 03:54:24 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bart Van Assche <bvanassche@....org>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
CC: Bean Huo <beanhuo@...ron.com>, Peter Wang <peter.wang@...iatek.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5 3/3] scsi: ufs: sysfs: Make max_number_of_rtt
 read-write

> 
> On 5/23/24 05:58, Avri Altman wrote:
> > +     /* make sure that there are no outstanding requests when rtt is set */
> > +     ufshcd_scsi_block_requests(hba);
> > +     blk_mq_wait_quiesce_done(&hba->host->tag_set);
> > +
> > +     ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
> > +             QUERY_ATTR_IDN_MAX_NUM_OF_RTT, 0, 0, &rtt);
> > +
> > +     ufshcd_scsi_unblock_requests(hba);
> 
> The above doesn't look correct to me. ufshcd_scsi_block_requests() does not
> guarantee that all pending commands have finished by the time it returns.
> Please blk_mq_freeze_queue() / blk_mq_unfreeze_queue() instead.
Thanks.  Will use those to drain the queues.

Thanks,
Avri

> 
> Thanks,
> 
> Bart.