linux-kernel - Re: [PATCH] ufs:mcq:Fixing Error Output for ufshcd_try_to_abort_task in ufshcd_mcq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb116abc-1ee6-42d0-879f-e11cdeab3cc5@acm.org>
Date: Thu, 23 May 2024 17:08:32 -0700
From: Bart Van Assche <bvanassche@....org>
To: Chanwoo Lee <cw9316.lee@...sung.com>
Cc: James.Bottomley@...senPartnership.com, alim.akhtar@...sung.com,
 avri.altman@....com, linux-kernel@...r.kernel.org,
 linux-scsi@...r.kernel.org, martin.petersen@...cle.com,
 powen.kao@...iatek.com, quic_cang@...cinc.com, quic_nguyenb@...cinc.com,
 stanley.chu@...iatek.com, yang.lee@...ux.alibaba.com
Subject: Re: [PATCH] ufs:mcq:Fixing Error Output for ufshcd_try_to_abort_task
 in ufshcd_mcq_abort

On 5/23/24 16:56, Chanwoo Lee wrote:
> I thought this patch would be appropriate to "fix" the following log.
>    * dev_err(hba->dev, "%s: device abort failed %d\n", __func__, err);
> If "Fixing" is not appropriate, could you suggest another word?

That's something I had not noticed. This is indeed a bug fix. Please add
a "Fixes:" tag as is expected for bug fixes.

BTW, I think that ufshcd_mcq_abort() can be improved significantly. How
about reworking that function as follows before the bug reported in this
patch is fixed?
- Remove the local variable 'err' (and reintroduce that variable in your
   patch).
- Change all 'goto out' statements into 'return FAILED'.
- Add 'return SUCCESS' at the end.

I expect that this change will make that function easier to read and to
maintain.

Thanks,

Bart.