linux-kernel - Re: [PATCH] mm: arm64: Fix the out-of-bounds issue in contpte_clear_young_dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9ed9876-db41-461e-9fb4-8932cc53331c@redhat.com>
Date: Fri, 24 May 2024 09:04:47 +0200
From: David Hildenbrand <david@...hat.com>
To: Barry Song <21cnbao@...il.com>, akpm@...ux-foundation.org,
 linux-mm@...ck.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Barry Song <v-songbaohua@...o.com>, Lance Yang <ioworker0@...il.com>,
 Ryan Roberts <ryan.roberts@....com>, Jeff Xie <xiehuan09@...il.com>,
 Kefeng Wang <wangkefeng.wang@...wei.com>, Michal Hocko <mhocko@...e.com>,
 Minchan Kim <minchan@...nel.org>, Muchun Song <songmuchun@...edance.com>,
 Peter Xu <peterx@...hat.com>, Yang Shi <shy828301@...il.com>,
 Yin Fengwei <fengwei.yin@...el.com>, Zach O'Keefe <zokeefe@...gle.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>
Subject: Re: [PATCH] mm: arm64: Fix the out-of-bounds issue in
 contpte_clear_young_dirty_ptes

On 24.05.24 02:54, Barry Song wrote:
> From: Barry Song <v-songbaohua@...o.com>
> 
> We are passing a huge nr to __clear_young_dirty_ptes() right
> now. While we should pass the number of pages, we are actually
> passing CONT_PTE_SIZE. This is causing lots of crashes of
> MADV_FREE, panic oops could vary everytime.
> 
> Fixes: 89e86854fb0a ("mm/arm64: override clear_young_dirty_ptes() batch helper")
> Cc: Lance Yang <ioworker0@...il.com>
> Cc: Barry Song <21cnbao@...il.com>
> Cc: Ryan Roberts <ryan.roberts@....com>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Jeff Xie <xiehuan09@...il.com>
> Cc: Kefeng Wang <wangkefeng.wang@...wei.com>
> Cc: Michal Hocko <mhocko@...e.com>
> Cc: Minchan Kim <minchan@...nel.org>
> Cc: Muchun Song <songmuchun@...edance.com>
> Cc: Peter Xu <peterx@...hat.com>
> Cc: Yang Shi <shy828301@...il.com>
> Cc: Yin Fengwei <fengwei.yin@...el.com>
> Cc: Zach O'Keefe <zokeefe@...gle.com>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will@...nel.org>
> Signed-off-by: Barry Song <v-songbaohua@...o.com>
> ---

LGTM

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb