linux-kernel - Re: [PATCH] xhci: Remove dead code in xhci_move_dequeue_past

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <768a8ca8-2ca5-1c41-16c2-b0b0421ce645@linux.intel.com>
Date: Fri, 24 May 2024 11:45:02 +0300
From: Mathias Nyman <mathias.nyman@...ux.intel.com>
To: Hector Martin <marcan@...can.st>, Mathias Nyman
 <mathias.nyman@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xhci: Remove dead code in xhci_move_dequeue_past_td()

On 24.5.2024 10.07, Hector Martin wrote:
> This codepath is trivially dead, since the function is never called with
> a non-NULL td (the only callsite is immediately preceded by a NULL guard).
> 

Yes, thanks, adding to queue.
Comment below tells this was destined to be removed earlier.

> -	 * We shouldn't hit this anymore as cached cancelled TRBs are given back
> -	 * after clearing the cache, but be on the safe side and keep it anyway
> -	 */
> -	if (!td) {
..

Thanks
Mathias