linux-kernel - Re: [PATCH] wifi: rtw89: chan: Use swap() instead of open coding it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5da17b58-c407-498b-a666-be98584c8011@web.de>
Date: Fri, 24 May 2024 12:18:46 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, abaci@...ux.alibaba.com,
 linux-wireless@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Ping-Ke Shih <pkshih@...ltek.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Kalle Valo <kvalo@...nel.org>
Subject: Re: [PATCH] wifi: rtw89: chan: Use swap() instead of open coding it

> Swap is a function interface that provides exchange function. To avoid
> code duplication, we can use swap function.

Would a wording approach (like the following) be a bit nicer
for the second sentence?

   Use existing swap() function instead of keeping duplicate source code.

How do you think about to apply the summary phrase “Use swap() in rtw89_swap_sub_entity()”?

> ./drivers/net/wireless/realtek/rtw89/chan.c:2336:32-33: WARNING opportunity for swap().
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9174

Would another indication be helpful for the involved analysis tool?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/coccinelle/misc/swap.cocci?h=v6.9

Regards,
Markus