linux-kernel - Re: [PATCH] dm vdo: remove unused struct 'uds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c063045-4bce-14e4-9930-77cc0ed2edad@redhat.com>
Date: Thu, 23 May 2024 20:57:53 -0400
From: Matthew Sakai <msakai@...hat.com>
To: linux@...blig.org
Cc: dm-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dm vdo: remove unused struct 'uds_attribute'

On 5/23/24 17:07, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> 'uds_attribute' is unused since
> commit a9da0fb6d8c6 ("dm vdo: remove all sysfs interfaces").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Yes, this was clearly an oversight on our part. Feel free to add:
Reviewed-by: Matthew Sakai <msakai@...hat.com>

> ---
>   drivers/md/dm-vdo/dedupe.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/md/dm-vdo/dedupe.c b/drivers/md/dm-vdo/dedupe.c
> index 117266e1b3ae..39ac68614419 100644
> --- a/drivers/md/dm-vdo/dedupe.c
> +++ b/drivers/md/dm-vdo/dedupe.c
> @@ -148,11 +148,6 @@
>   #include "vdo.h"
>   #include "wait-queue.h"
>   
> -struct uds_attribute {
> -	struct attribute attr;
> -	const char *(*show_string)(struct hash_zones *hash_zones);
> -};
> -
>   #define DEDUPE_QUERY_TIMER_IDLE 0
>   #define DEDUPE_QUERY_TIMER_RUNNING 1
>   #define DEDUPE_QUERY_TIMER_FIRED 2