linux-kernel - Re: [PATCH 09/13] mm/memory-failure: remove obsolete comment in unpoison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93f3b2cb-7f79-4556-b3de-1aee015a2382@redhat.com>
Date: Fri, 24 May 2024 17:06:36 +0200
From: David Hildenbrand <david@...hat.com>
To: Miaohe Lin <linmiaohe@...wei.com>, akpm@...ux-foundation.org,
 tony.luck@...el.com, bp@...en8.de
Cc: nao.horiguchi@...il.com, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org
Subject: Re: [PATCH 09/13] mm/memory-failure: remove obsolete comment in
 unpoison_memory()

On 24.05.24 11:13, Miaohe Lin wrote:
> Since commit 130d4df57390 ("mm/sl[au]b: rearrange struct slab fields to
> allow larger rcu_head"), folio->_mapcount is not overloaded with SLAB.
> Update corresponding comment.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>   mm/memory-failure.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 19d338e83e43..e4252f297d41 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -2610,10 +2610,6 @@ int unpoison_memory(unsigned long pfn)
>   	    folio_test_reserved(folio) || folio_test_offline(folio))
>   		goto unlock_mutex;
>   
> -	/*
> -	 * Note that folio->_mapcount is overloaded in SLAB, so the simple test
> -	 * in folio_mapped() has to be done after folio_test_slab() is checked.
> -	 */
>   	if (folio_mapped(folio)) {
>   		unpoison_pr_info("Unpoison: Someone maps the hwpoison page %#lx\n",
>   				 pfn, &unpoison_rs);

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb