[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <18259f7c-d57e-4504-91ec-90b7c87aad01@redhat.com>
Date: Fri, 24 May 2024 17:12:54 +0200
From: David Hildenbrand <david@...hat.com>
To: Chengming Zhou <chengming.zhou@...ux.dev>,
Andrew Morton <akpm@...ux-foundation.org>, aarcange@...hat.com,
hughd@...gle.com, shr@...kernel.io
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
zhouchengming@...edance.com
Subject: Re: [PATCH 1/4] mm/ksm: refactor out try_to_merge_with_zero_page()
On 24.05.24 10:56, Chengming Zhou wrote:
> In preparation for later changes, refactor out a new function called
> try_to_merge_with_zero_page(), which tries to merge with zero page.
>
> Signed-off-by: Chengming Zhou <chengming.zhou@...ux.dev>
> ---
> mm/ksm.c | 67 +++++++++++++++++++++++++++++++++++-----------------------------
> 1 file changed, 37 insertions(+), 30 deletions(-)
>
> diff --git a/mm/ksm.c b/mm/ksm.c
> index 4dc707d175fa..cbd4ba7ea974 100644
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -1531,6 +1531,41 @@ static int try_to_merge_one_page(struct vm_area_struct *vma,
> return err;
> }
>
> +/* This function returns 0 if the pages were merged, -EFAULT otherwise. */
No it doesn't. Check the "err = 0" case.
--
Cheers,
David / dhildenb
Powered by blists - more mailing lists