lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 24 May 2024 16:58:22 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: dmitry.torokhov@...il.com, christophe.jaillet@...adoo.fr
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: tca6416 remove unused struct 'tca6416_drv_data'

* linux@...blig.org (linux@...blig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> 'tca6416_drv_data' is unused since the original
> commit 30ba3ead0576 ("Input: add keypad driver for keys interfaced to
> TCA6416").
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Oops, looks like Christophe got there first!

Dave

> ---
>  drivers/input/keyboard/tca6416-keypad.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/input/keyboard/tca6416-keypad.c b/drivers/input/keyboard/tca6416-keypad.c
> index 677bc4baa5d1..b2060229bd0f 100644
> --- a/drivers/input/keyboard/tca6416-keypad.c
> +++ b/drivers/input/keyboard/tca6416-keypad.c
> @@ -32,11 +32,6 @@ static const struct i2c_device_id tca6416_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, tca6416_id);
>  
> -struct tca6416_drv_data {
> -	struct input_dev *input;
> -	struct tca6416_button data[];
> -};
> -
>  struct tca6416_keypad_chip {
>  	uint16_t reg_output;
>  	uint16_t reg_direction;
> -- 
> 2.45.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ