linux-kernel - Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5db69319-4d61-7637-8bde-5d786e5faea4@quicinc.com>
Date: Fri, 24 May 2024 11:19:41 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Junhao Xie <bigfoot@...ssfun.cn>, Rob Clark <robdclark@...il.com>,
        Dmitry
 Baryshkov <dmitry.baryshkov@...aro.org>,
        Sean Paul <sean@...rly.run>,
        Marijn
 Suijten <marijn.suijten@...ainline.org>,
        David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Ryan McCann <quic_rmccann@...cinc.com>,
        Neil Armstrong
	<neil.armstrong@...aro.org>,
        Jonathan Marek <jonathan@...ek.ca>
CC: <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats
 arrays



On 5/24/2024 8:01 AM, Junhao Xie wrote:
> There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv,
> which cause weston assertions failed.
> 
> weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format:
> Assertion `!weston_drm_format_array_find_format(formats, format)' failed.
> 
> Signed-off-by: Junhao Xie <bigfoot@...ssfun.cn>
> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 ------
>   1 file changed, 6 deletions(-)
> 

I think we need two fixes tag here, one for the RGB array and the other 
one for the RGB+YUV array.

Fixes: 8c16b988ba2d ("drm/msm/dpu: introduce separate wb2_format arrays 
for rgb and yuv")

Fixes: 53324b99bd7b ("drm/msm/dpu: add writeback blocks to the sm8250 
DPU catalog")

Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>

(pls ignore the line breaks in the fixes line, I will fix it while applying)