linux-kernel - Re: [PATCH v4] usb-storage: Check whether the media is initialized successfully

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACjpba7uNtPPDAh+mkHc5fU2vzTGiTWkkS9WOqkPZ5sXQXZPGg@mail.gmail.com>
Date: Sat, 25 May 2024 21:46:44 +0800
From: shichao lai <shichaorai@...il.com>
To: Alan Stern <stern@...land.harvard.edu>, gregkh@...uxfoundation.org, oneukum@...e.com
Cc: linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net, 
	linux-kernel@...r.kernel.org, xingwei lee <xrivendell7@...il.com>, 
	yue sun <samsun1006219@...il.com>
Subject: Re: [PATCH v4] usb-storage: Check whether the media is initialized successfully

> Oliver did not suggest that the patch be written this way.
>
> Now with the patch written out, I think a better name for this variable
> would be media_initialized.  That is a better description of what it
> means (it doesn't mean that the driver or the device is initialized).
> And then you could remove the comment, because it would be obvious.
>
> You don't need to do this.  The info pointer is an alias for us->extra,
> which is allocated by kzalloc(), which clears all the memory it
> allocates to zero.
>
> Alan Stern

Thanks for your patient feedback!
I will rewrite the patch soon.