[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <bd01676e-edf2-42e2-a689-d9a89819c490@kernel.org>
Date: Sat, 25 May 2024 19:01:18 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: joelselvaraj.oss@...il.com, Hans de Goede <hdegoede@...hat.com>,
Dmitry Torokhov <dmitry.torokhov@...il.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Ilpo Järvinen
<ilpo.jarvinen@...ux.intel.com>
Cc: linux-input@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: input: document Novatek NVT
touchscreen controller
On 24/05/2024 16:39, Joel Selvaraj via B4 Relay wrote:
> From: Joel Selvaraj <joelselvaraj.oss@...il.com>
>
> Document the Novatek NVT touchscreen controller present in devices like
> the Xiaomi Poco F1 [1]. Also, include the devictree binding file in the
Just name the DTS, no need for external link.
> MAINTAINERS file.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts?h=v6.9
>
> +
> + vcc-supply: true
> + iovcc-supply: true
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + touchscreen@1 {
> + compatible = "novatek,nt36672a-ts";
Messed indentation. Use 4 spaces for example indentation.
With above fixes:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists