linux-kernel - Re: [PATCH 04/13] mm/memory-failure: save a page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78e22db5-791d-0086-f6a3-8c9bba2ca4cc@huawei.com>
Date: Sat, 25 May 2024 09:34:20 +0800
From: Miaohe Lin <linmiaohe@...wei.com>
To: David Hildenbrand <david@...hat.com>
CC: <nao.horiguchi@...il.com>, <linux-mm@...ck.org>,
	<linux-kernel@...r.kernel.org>, <linux-edac@...r.kernel.org>,
	<akpm@...ux-foundation.org>, <tony.luck@...el.com>, <bp@...en8.de>
Subject: Re: [PATCH 04/13] mm/memory-failure: save a page_folio() call

On 2024/5/24 23:06, David Hildenbrand wrote:
> On 24.05.24 11:13, Miaohe Lin wrote:
>> Use local variable folio directly to save a page_folio() call.
>> No functional change intended.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>> ---
>>   mm/memory-failure.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
>> index b571aaf987a2..73878ecdec22 100644
>> --- a/mm/memory-failure.c
>> +++ b/mm/memory-failure.c
>> @@ -1658,7 +1658,7 @@ static bool hwpoison_user_mappings(struct folio *folio, struct page *p,
>>       unmap_success = !page_mapped(p);
> 
> We should be using folio_mapped() here.

Will fix this.

> 
>>       if (!unmap_success)
>>           pr_err("%#lx: failed to unmap page (folio mapcount=%d)\n",
>> -               pfn, folio_mapcount(page_folio(p)));
>> +               pfn, folio_mapcount(folio));
> 
> Reviewed-by: David Hildenbrand <david@...hat.com>

Thanks for your comment.
.