linux-kernel - Re: [PATCH] selftests/mm: Fix build warnings on ppc64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c6a02989-b50b-4cb3-891e-a45be9391731@collabora.com>
Date: Fri, 24 May 2024 21:32:46 -0700
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Michael Ellerman <mpe@...erman.id.au>, linux-kselftest@...r.kernel.org,
 skhan@...uxfoundation.org
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 akpm@...ux-foundation.org, linux-mm@...ck.org
Subject: Re: [PATCH] selftests/mm: Fix build warnings on ppc64

On 5/20/24 8:02 PM, Michael Ellerman wrote:
> Fix warnings like:
> 
>   In file included from uffd-unit-tests.c:8:
>   uffd-unit-tests.c: In function ‘uffd_poison_handle_fault’:
>   uffd-common.h:45:33: warning: format ‘%llu’ expects argument of type
>   ‘long long unsigned int’, but argument 3 has type ‘__u64’ {aka ‘long
>   unsigned int’} [-Wformat=]
> 
> By switching to unsigned long long for u64 for ppc64 builds.
> 
> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  tools/testing/selftests/mm/gup_test.c    | 1 +
>  tools/testing/selftests/mm/uffd-common.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c
> index bd335cf9bc0e..bdeaac67ff9a 100644
> --- a/tools/testing/selftests/mm/gup_test.c
> +++ b/tools/testing/selftests/mm/gup_test.c
> @@ -1,3 +1,4 @@
> +#define __SANE_USERSPACE_TYPES__ // Use ll64
>  #include <fcntl.h>
>  #include <errno.h>
>  #include <stdio.h>
> diff --git a/tools/testing/selftests/mm/uffd-common.h b/tools/testing/selftests/mm/uffd-common.h
> index cc5629c3d2aa..a70ae10b5f62 100644
> --- a/tools/testing/selftests/mm/uffd-common.h
> +++ b/tools/testing/selftests/mm/uffd-common.h
> @@ -8,6 +8,7 @@
>  #define __UFFD_COMMON_H__
>  
>  #define _GNU_SOURCE
> +#define __SANE_USERSPACE_TYPES__ // Use ll64
>  #include <stdio.h>
>  #include <errno.h>
>  #include <unistd.h>

-- 
BR,
Muhammad Usama Anjum