linux-kernel - Re: [PATCH v5 2/5] clk: imx: clk-audiomix: Add reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c53b063-ad12-405d-b088-9b992284ba08@web.de>
Date: Sat, 25 May 2024 09:26:53 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Shengjiu Wang <shengjiu.wang@....com>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 kernel-janitors@...r.kernel.org, imx@...ts.linux.dev,
 Abel Vesa <abelvesa@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Fabio Estevam <festevam@...il.com>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Marek Vasut <marex@...x.de>,
 Michael Turquette <mturquette@...libre.com>, Peng Fan <peng.fan@....com>,
 Philipp Zabel <p.zabel@...gutronix.de>, Sascha Hauer
 <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel@...gutronix.de,
 Shengjiu Wang <shengjiu.wang@...il.com>
Subject: Re: [PATCH v5 2/5] clk: imx: clk-audiomix: Add reset controller

…
> The reset controller is supported by the auxiliary device
> framework.

Would you like to add an imperative wording for an improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94


…
> +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c
…
> +static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev,
> +							 struct clk_imx8mp_audiomix_priv *priv)
> +{
> +	struct auxiliary_device __free(kfree) * adev = NULL;
> +	int ret;
> +
> +	adev = kzalloc(sizeof(*adev), GFP_KERNEL);
…

May the following source code variant be applied here?

	int ret;
	struct auxiliary_device __free(kfree) *adev = kzalloc(sizeof(*adev), GFP_KERNEL);


Regards,
Markus