linux-kernel - Re: [PATCH 1/3] staging: rtl8192e: reduce indentation level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 26 May 2024 16:23:11 +0200
From: Nam Cao <namcao@...utronix.de>
To: Michael Straube <straube.linux@...il.com>
Cc: gregkh@...uxfoundation.org, philipp.g.hortmann@...il.com,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8192e: reduce indentation level

On Sun, May 26, 2024 at 01:19:26PM +0200, Michael Straube wrote:
> Reduce indentation level in _rtl92e_dm_rx_path_sel_byrssi() by negating
> if statements and use continue in for loops. This way the indentation
> level of the code that is covered by the if checks can be reduced. This
> improves readability and clears two checkpatch warnings.
> 
> WARNING: Too many leading tabs - consider code refactoring
> 
> Signed-off-by: Michael Straube <straube.linux@...il.com>

I don't see any functional change. This patch does as described:

Reviewed-by: Nam Cao <namcao@...utronix.de>

Best regards,
Nam