linux-kernel - Re: [PATCH] HID: nintendo: Fix an error handling path in nintendo_hid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <31TNA0FQDFO0L.21EUCKC20GDGV@homearch.localdomain>
Date: Sun, 26 May 2024 17:48:51 +0200
From: "Silvan Jegen" <s.jegen@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: "Daniel J. Ogorchock" <djogorchock@...il.com>, Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>, Martino Fontana <tinozzo123@...il.com>, Ryan McClelland <rymcclel@...il.com>, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: nintendo: Fix an error handling path in nintendo_hid_probe()

Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:
> joycon_leds_create() has a ida_alloc() call. So if an error occurs after
> it, a corresponding ida_free() call is needed, as already done in the
> .remove function.
> 
> This is not 100% perfect, because if ida_alloc() fails, then
> 'ctlr->player_id' will forced to be U32_MAX, and an error will be logged
> when ida_free() is called.
> 
> Considering that this can't happen in real life, no special handling is
> done to handle it.
> 
> Fixes: 5307de63d71d ("HID: nintendo: use ida for LED player id")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/hid/hid-nintendo.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

LGTM!

Reviewed-by: Silvan Jegen <s.jegen@...il.com>