Message-ID: <eeb46ba769f6ee9a1972cd104f0de19d@manjaro.org>
Date: Sun, 26 May 2024 18:40:12 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Andre Przywara <andre.przywara@....com>
Cc: Icenowy Zheng <uwu@...nowy.me>, linux-sunxi@...ts.linux.dev,
 wens@...e.org, jernej.skrabec@...il.com, samuel@...lland.org,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 robh+dt@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-kernel@...r.kernel.org, didi.debian@...ow.org, Marek Kraus
 <gamiee@...e64.org>
Subject: Re: [PATCH 1/2] dt-bindings: arm: sunxi: Correct the descriptions for
 Pine64 boards

Hello Andre and Icenowy,

On 2024-05-22 15:06, Dragan Simic wrote:
> On 2024-05-22 12:05, Andre Przywara wrote:
>> On Wed, 22 May 2024 08:10:21 +0200
>> Dragan Simic <dsimic@...jaro.org> wrote:
>>> On 2024-05-22 02:48, Icenowy Zheng wrote:
>>> > 在 2024-04-23星期二的 03:00 +0200，Dragan Simic写道：
>>> >> Correct the descriptions of a few Pine64 boards and devices,
>>> >> according
>>> >> to their official names used on the Pine64 wiki.  This ensures
>>> >> consistency
>>> >> between the officially used names and the names in the source code.
>>> >>
>>> >> [...]
>>> >>
>>> >> -      - description: Pine64 PineH64 model A
>>> >> +      - description: Pine64 H64 Model A
>>> >>          items:
>>> >>            - const: pine64,pine-h64
>>> >>            - const: allwinner,sun50i-h6
>>> >>  
>>> >> -      - description: Pine64 PineH64 model B
>>> >> +      - description: Pine64 H64 Model B
>>> >
>>> > Sorry for replying so late, but I don't think there is a Pine64 H64
>>> > board. The Pine64 wiki calls it Pine H64. [1]
>>> >
>>> > [1] https://wiki.pine64.org/wiki/PINE_H64
>>> 
>>> Good point, thanks.  Though, this board is really an exception to
>>> the naming scheme employed for the Pine64 boards, so perhaps it would
>>> actually be better to rename the board in the Pine64 wiki, by adding
>>> "64" to "Pine", to ensure consistency.
>> 
>> I am sorry, but I don't think this is how it works. The board is 
>> really
>> called "Pine H64", that's printed on the board [1] and everywhere else 
>> [2].
>> That's a choice the manufacturer made, and renaming some Wiki page 
>> won't
>> change that. I understand the engineer's desire to make everything 
>> nice and
>> consistent ;-) , but I am afraid that's not our call. After all this 
>> file
>> is to document the device naming, not to be an example of consistent
>> naming schemes.
>> 
>> [1] https://linux-sunxi.org/images/5/53/Pineh64_top.jpg
>> [2] https://pine64.org/devices/pine_h64_model_a/
> 
> Those are all valid concerns.  Though, when it comes to the 
> silkscreened
> labels on PCBs, sometimes they have no connection with the real, 
> official
> board names.  An almost funny example :) is the QuartzPro64 board, also
> from Pine64. [3]
> 
> I'll check with Pine64 are there some intentions for unifying the 
> officially
> used board names, and if there aren't, I'll submit the v2 of this 
> series
> with the corrected board names.
> 
> [3] 
> https://wiki.pine64.org/images/f/fe/Quartzpro64_whole_board_top_resized.jpeg

It's been decided that the history should be preserved, so I'll prepare
and submit the v2 of this series with the original Pine64 board names 
that
are currently used officially.

>>> Alas, the Pine64 wiki is currently in read-only mode, due to some
>>> recent issues with the underlying hardware that runs it.  Migration 
>>> to
>>> another form of documentation for Pine64 boards is also a 
>>> possibility,
>>> which makes the updates even more complicated.
>>> 
>>> With all this in mind, I think it would be the best to rename the 
>>> board
>>> on the Pine64 side, to ensure consistency, and keep this patch as-is.
>>> I'll make a mental note to do that on the Pine64 side once the 
>>> current
>>> situation with the Pine64 wiki is resolved.

Powered by blists - more mailing lists