linux-kernel - Re: [v6] usb-storage: alauda: Check whether the media is initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 26 May 2024 11:20:23 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Shichao Lai <shichaorai@...il.com>, usb-storage@...ts.one-eyed-alien.net,
 linux-usb@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Alan Stern <stern@...land.harvard.edu>
Cc: LKML <linux-kernel@...r.kernel.org>, Oliver Neukum <oneukum@...e.com>,
 Xingwei Lee <xrivendell7@...il.com>, Yue Sun <samsun1006219@...il.com>
Subject: Re: [v6] usb-storage: alauda: Check whether the media is initialized

>> …
>>> Fixes: e80b0fade09e ("[PATCH] USB Storage: add alauda support")
>>
>> How do you think about to omit the text “[PATCH] ” from the tag summary?
>
> Then it would be incorrect.

I find this view interesting.

> Again, Markus, please STOP sending review comments that are obviously wrong.

The mentioned tag needs an “one line summary”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n145

Do you find it required to repeat a questionable commit subject completely?

> New developers do not know who to ignore and you are telling
> them things that are wrong and not helpful at all.

Additional development views can occasionally become helpful.

> Please stop reviewing patches,

Patch review is one of the usual software development activities.

> this is not ok

I suggest to reconsider such a view once more.

> is actually harmful to our community.

Possible improvements are varying between affected software components.

Regards,
Markus