linux-kernel - Re: [PATCH] dt-bindings: usb: qcom,dwc3: set minItems for interrupt-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f709f17d-c20c-4777-b23b-8275f6d4f3f5@kernel.org>
Date: Mon, 27 May 2024 17:13:39 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bartosz Golaszewski <brgl@...ev.pl>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Wesley Cheng <quic_wcheng@...cinc.com>
Cc: linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
Subject: Re: [PATCH] dt-bindings: usb: qcom,dwc3: set minItems for
 interrupt-names

On 27/05/2024 16:45, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> There's a set of compatibles for which we set a strict list of 5 interrupt
> names even though minItems for the interrupts property is 4. One of the
> USB controllers on sa8775p only consumes 4 interrupts which leads to
> dtbs_check errors. Make the last entry optional by setting minItems to 4.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
>  Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
>  1 file changed, 1 insertion(+)

Can you also fix other cases? I found there at least two other. I missed
that during review... or maybe we discussed it? I remember that commit
was a pain :/

The commits from quicinc fix one issue and bring immediately one more.

But be sure that this is what we actually want. Maybe intention was to
have fixed number of interrupts (so no minItems in interrupts)?

Also, in any case:
Fixes: 53c6d854be4e ("dt-bindings: usb: dwc3: Clean up hs_phy_irq in
binding")


Best regards,
Krzysztof