linux-kernel - Re: [PATCH v2] clocksource: Add node counter timer driver for MIPS/Loongson64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9947f7a5-1a95-48f2-b0eb-0385eb2b3d55@app.fastmail.com>
Date: Mon, 27 May 2024 17:32:13 +0100
From: "Jiaxun Yang" <jiaxun.yang@...goat.com>
To: "Thomas Gleixner" <tglx@...utronix.de>,
 "Huacai Chen" <chenhuacai@...nel.org>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
 "Daniel Lezcano" <daniel.lezcano@...aro.org>
Cc: linux-kernel@...r.kernel.org,
 "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH v2] clocksource: Add node counter timer driver for MIPS/Loongson64



在2024年5月27日五月 下午4:51，Thomas Gleixner写道：
> Jiaxun!
>
Hi Thomas,
[...]
>
> What's this indirection for? Why dont you update 
[...]
>
>> +static struct clocksource nodecnt_clocksource = {
>> +	.name	= "nodecnt",
>> +	.read	= nodecnt_clocksource_read,
>
> the read function pointer here and spare the indirection?
Smart! sched_clock takes slightly different function pointer argument type
but as we don't use the argument anyway, it should be safe to relax this
indirection.

Will fix in v3.

Thanks
>
> Thanks
>
>         tglx

-- 
- Jiaxun