linux-kernel - Re: [PATCH] dmaengine: xilinx: xdma: Fixes possible threading issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0eaf77b-eed9-4f8e-8009-983250fa56a8@web.de>
Date: Mon, 27 May 2024 20:32:05 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Louis Chauvet <louis.chauvet@...tlin.com>, dmaengine@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, Brian Xu <brian.xu@....com>,
 Lizhi Hou <lizhi.hou@....com>, Michal Simek <michal.simek@....com>,
 Raj Kumar Rampelli <raj.kumar.rampelli@....com>,
 Vinod Koul <vkoul@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: xilinx: xdma: Fixes possible threading issue

> The current interrupt handler in xdma.c was using xdma->stop_request
> before locking the vchan lock.

1. Will an additional imperative wording become helpful here?
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc1#n94

2. How do you think about to use the summary phrase “Fix data synchronisation in xdma_channel_isr()”?

3. Will development interests grow for the usage of a statement like “guard(spin)(&xchan->vchan.lock);”?
   https://elixir.bootlin.com/linux/v6.10-rc1/source/include/linux/cleanuph#L124

Regards,
Markus