linux-kernel - Re: [PATCH net-next v5 1/3] net: ti: icssg-prueth: Add helper functions to configure FDB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cf97632-4d77-4f28-bed6-7d40d61d958f@lunn.ch>
Date: Tue, 28 May 2024 00:04:25 +0200
From: Andrew Lunn <andrew@...n.ch>
To: MD Danish Anwar <danishanwar@...com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>,
	Jan Kiszka <jan.kiszka@...mens.com>,
	Simon Horman <horms@...nel.org>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Niklas Schnelle <schnelle@...ux.ibm.com>,
	Arnd Bergmann <arnd@...db.de>, Diogo Ivo <diogo.ivo@...mens.com>,
	Roger Quadros <rogerq@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, srk@...com,
	Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH net-next v5 1/3] net: ti: icssg-prueth: Add helper
 functions to configure FDB

> +struct mgmt_cmd {
> +	u8 param;
> +	u8 seqnum;
> +	u8 type;
> +	u8 header;
> +	u32 cmd_args[3];
> +} __packed;

There is a general dislike for __packed. Since your structures are
naturally well aligned, it is probably not needed. You could be
paranoid and add BUILD_BUG_ON(sizeof(struct mgmt_cmd) != 16);

	 Andrew