linux-kernel - Re: [PATCH v3 2/6] thermal: Add support of multi sensors to thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec830d15-c717-4b81-bda8-6018a4c84258@linaro.org>
Date: Mon, 27 May 2024 09:02:11 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Alexandre Bailon <abailon@...libre.com>, rafael@...nel.org,
 daniel.lezcano@...aro.org, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: rui.zhang@...el.com, lukasz.luba@....com, linux-pm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/6] thermal: Add support of multi sensors to
 thermal_core

On 27/05/2024 09:00, Krzysztof Kozlowski wrote:
> On 24/05/2024 16:31, Alexandre Bailon wrote:
>> This adds support of multi sensors to thermal.
>> Currently, this only support the get_temp operation.
>> This returns an average temperature of all the sensors.
>> If defined, a coefficient is applied to the value read from the sensor
>> before computing the average.
>>
>> Signed-off-by: Alexandre Bailon <abailon@...libre.com>
>> ---
>>  drivers/thermal/Makefile        |   1 +
>>  drivers/thermal/thermal_core.h  |  15 ++
>>  drivers/thermal/thermal_multi.c | 332 ++++++++++++++++++++++++++++++++
>>  include/uapi/linux/thermal.h    |   5 +
>>  4 files changed, 353 insertions(+)
>>  create mode 100644 drivers/thermal/thermal_multi.c
> 
> This does not really build...
> 
> 
> ../drivers/thermal/thermal_multi.c:249:38: error: initialization of ‘struct thermal_trip *’ from incompatible pointer type ‘struct thermal_trip_desc *’ [-Werror=incompatible-pointer-types]

and there are other warnings:

warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst


Best regards,
Krzysztof