linux-kernel - Re: [PATCH 1/4] mm/ksm: refactor out try_to_merge_with_zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18ad1a9f-8f00-41c1-9c77-ac3252061852@redhat.com>
Date: Mon, 27 May 2024 09:18:13 +0200
From: David Hildenbrand <david@...hat.com>
To: Chengming Zhou <chengming.zhou@...ux.dev>,
 Andrew Morton <akpm@...ux-foundation.org>, aarcange@...hat.com,
 hughd@...gle.com, shr@...kernel.io
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 zhouchengming@...edance.com
Subject: Re: [PATCH 1/4] mm/ksm: refactor out try_to_merge_with_zero_page()

Am 27.05.24 um 06:36 schrieb Chengming Zhou:
> On 2024/5/24 23:12, David Hildenbrand wrote:
>> On 24.05.24 10:56, Chengming Zhou wrote:
>>> In preparation for later changes, refactor out a new function called
>>> try_to_merge_with_zero_page(), which tries to merge with zero page.
>>>
>>> Signed-off-by: Chengming Zhou <chengming.zhou@...ux.dev>
>>> ---
>>>    mm/ksm.c | 67 +++++++++++++++++++++++++++++++++++-----------------------------
>>>    1 file changed, 37 insertions(+), 30 deletions(-)
>>>
>>> diff --git a/mm/ksm.c b/mm/ksm.c
>>> index 4dc707d175fa..cbd4ba7ea974 100644
>>> --- a/mm/ksm.c
>>> +++ b/mm/ksm.c
>>> @@ -1531,6 +1531,41 @@ static int try_to_merge_one_page(struct vm_area_struct *vma,
>>>        return err;
>>>    }
>>>    +/* This function returns 0 if the pages were merged, -EFAULT otherwise. */
>>
>> No it doesn't. Check the "err = 0" case.
>>
> 
> Right, how about this: This function returns 0 if the page were merged or the vma
> is out of date, which means we don't need to continue, -EFAULT otherwise.

Maybe slightly adjusted:

This function returns 0 if the pages were merged or if they are no longer 
merging candidates (e.g., VMA stale), -EFAULT otherwise.

-- 
Thanks,

David / dhildenb