linux-kernel - RE: [EXTERNAL] Re: [PATCH v4 5/5] spi: cadence: Add MRVL overlay xfer operation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 27 May 2024 08:20:42 +0000
From: Witold Sadowski <wsadowski@...vell.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
CC: "broonie@...nel.org" <broonie@...nel.org>,
        "robh@...nel.org"
	<robh@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org"
	<conor+dt@...nel.org>,
        "pthombar@...ence.com" <pthombar@...ence.com>
Subject: RE: [EXTERNAL] Re: [PATCH v4 5/5] spi: cadence: Add MRVL overlay xfer
 operation support

> ----------------------------------------------------------------------
> On 09/05/2024 03:05, Witold Sadowski wrote:
> > MRVL Xfer overlay extend xSPI capabilities, to support non-memory SPI
> > operations. Marvell overlay combined with generic command allows to
> > create full-duplex SPI transactions. It also allows to create
> > transaction with undetermined transaction length - with cs_hold
> > parameter, and ability to extend CS signal assertion, even if xSPI
> > block requests CS signal de-assertion.
> >
> 
> 
> > +
> >  static int cdns_xspi_probe(struct platform_device *pdev)  {
> >  	struct device *dev = &pdev->dev;
> > @@ -905,6 +1140,16 @@ static int cdns_xspi_probe(struct platform_device
> *pdev)
> >  		return PTR_ERR(cdns_xspi->auxbase);
> >  	}
> >
> > +	if (cdns_xspi->mrvl_hw_overlay) {
> > +		res = platform_get_resource(pdev, IORESOURCE_MEM, 3);
> > +		cdns_xspi->xferbase = devm_ioremap_resource(dev, res);
> 
> Use proper wrapper/helper for these two. This looks like you are working
> on old, downstream kernel.

Ok, changed to devm_devm_platform_ioremap_resource()

> 
> Best regards,
> Krzysztof

Regards
Witek