linux-kernel - Re: [PATCH] sched/fair: Reschedule the cfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9bf8022b4bbeb0bbd06df0e81a8ca2ea2802e7b.camel@gmx.de>
Date: Mon, 27 May 2024 11:53:28 +0200
From: Mike Galbraith <efault@....de>
To: Peter Zijlstra <peterz@...radead.org>, kprateek.nayak@....com
Cc: Chunxin Zang <spring.cxz@...il.com>, mingo@...hat.com, 
 juri.lelli@...hat.com, vincent.guittot@...aro.org,
 dietmar.eggemann@....com,  rostedt@...dmis.org, bsegall@...gle.com,
 mgorman@...e.de, bristot@...hat.com,  vschneid@...hat.com,
 linux-kernel@...r.kernel.org, yu.c.chen@...el.com,  yangchen11@...iang.com,
 zhouchunhua@...iang.com, zangchunxin@...iang.com
Subject: Re: [PATCH] sched/fair: Reschedule the cfs_rq when current is
 ineligible

On Mon, 2024-05-27 at 10:05 +0200, Peter Zijlstra wrote:
> On Sat, May 25, 2024 at 08:41:28AM +0200, Mike Galbraith wrote:
> 
> > -       if (pick_eevdf(cfs_rq) == pse)
> > -               goto preempt;
> > -
> > -       return;
> > +       if (pick_eevdf(cfs_rq) == se)
> > +               return;
> 
> Right, this will preempt more.

Yeah, and for no tangible benefit that I can see.  Repeating the mixed
load GUI vs compute testing a bunch of times, there's enough variance
to swamp any signal.

	-Mike