linux-kernel - Re: [PATCH 2/2] platform/x86: ISST: Use only TPMI interface when present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3e92568-3440-cb45-e6b0-90133aa8a9b1@linux.intel.com>
Date: Mon, 27 May 2024 13:03:20 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
cc: Hans de Goede <hdegoede@...hat.com>, 
    Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
    platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] platform/x86: ISST: Use only TPMI interface when
 present

On Thu, 9 May 2024, Srinivas Pandruvada wrote:

> When the TPMI interface is present, use this interface instead of legacy.
> On some systems legacy IO device is also present. Using both interfaces
> together is confusing and may set the hardware in inconsistent state.
> 
> When TPMI interface is present, don't load legacy drivers.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Reviewed-by: Zhang Rui <rui.zhang@...el.com
> ---
>  drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> index f886f9369fad..6283af37e73b 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> @@ -775,6 +775,9 @@ int isst_if_cdev_register(int device_type, struct isst_if_cmd_cb *cb)
>  	if (device_type >= ISST_IF_DEV_MAX)
>  		return -EINVAL;
>  
> +	if (device_type < ISST_IF_DEV_TPMI && isst_hpm_support)
> +		return -ENODEV;

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.