linux-kernel - Re: [PATCH] tpm: Open code tpm_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 27 May 2024 14:00:45 +0300
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Paul Menzel" <pmenzel@...gen.mpg.de>
Cc: <linux-integrity@...r.kernel.org>, <keyrings@...r.kernel.org>,
 <James.Bottomley@...senPartnership.com>, "Peter Huewe" <peterhuewe@....de>,
 "Jason Gunthorpe" <jgg@...pe.ca>, "Mimi Zohar" <zohar@...ux.ibm.com>,
 "David Howells" <dhowells@...hat.com>, "Paul Moore" <paul@...l-moore.com>,
 "James Morris" <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>,
 "Stefan Berger" <stefanb@...ux.ibm.com>, "Ard Biesheuvel"
 <ardb@...nel.org>, "Mario Limonciello" <mario.limonciello@....com>,
 <linux-kernel@...r.kernel.org>, <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH] tpm: Open code tpm_buf_parameters()

On Sun May 26, 2024 at 8:42 AM EEST, Paul Menzel wrote:
> Dear Jarkko,
>
>
> Thank you for your patch.
>
> Am 25.05.24 um 17:44 schrieb Jarkko Sakkinen:
> > With only single call site, this no sense, and it actually slipped out
>
> this *makes* no sense?

Thanks for the remark :-)

>
> > of the radar during the review. Open code and document the action
> > directly to the site, to make it more readable.
>
> […]
>
>
> Kind regards,
>
> Paul

In order not to have to recycle this, does this now make sense to you:

https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=b6b88cde77e7c30ab8f534d723ad9c4ec15b7753

Unless actual critical fixes for hmac, probably will save this to v6.11
but with some "real" fixes I'll piggy pack it to rcX.

BR, Jarkko