linux-kernel - Re: [PATCH] net: usb: smsc95xx: configure external LEDs function for EVB-LAN8670-USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <677474fd-746c-4b27-a65e-3bff6daa0b01@microchip.com>
Date: Mon, 27 May 2024 11:42:45 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <oneukum@...e.com>, <steve.glendinning@...well.net>,
	<UNGLinuxDriver@...rochip.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>
CC: <netdev@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: usb: smsc95xx: configure external LEDs function for
 EVB-LAN8670-USB

Hi Oliver,

On 27/05/24 1:58 pm, Oliver Neukum wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know 
> the content is safe
> 
> On 22.05.24 16:08, Parthiban Veerasooran wrote:
> 
> Hi,
> 
> however you solve this, the descriptors are stored in wire order.
> 
>> +     if (dev->udev->descriptor.idVendor == 0x184F &&
>> +         dev->udev->descriptor.idProduct == 0x0051)
>> +             write_buf |= LED_GPIO_CFG_LED_SEL;
> 
> This needs to be
> 
> if (dev->udev->descriptor.idVendor == cpu_to_le16(0x184F) &&
>         dev->udev->descriptor.idProduct == cpu_to_le16(0x0051))
> 
>         HTH
>                 Oliver
Thanks for reviewing the patch. This one was already pointed out by 
Simon Horman and kernel test robot. I agreed that but unfortunately 
there was an another proposal by Woojung with EEPROM. So I asked to 
discard this patch proceeding further and sent out another fix patch for 
supporting with Woojung's EEPROM proposal.

My request to discard this patch:
---------------------------------
https://lore.kernel.org/netdev/3e2b2b18-4dd9-4b22-9690-01e1bdd44828@microchip.com/

My request to review the other/new patch:
-----------------------------------------
https://lore.kernel.org/netdev/20240523085314.167650-1-Parthiban.Veerasooran@microchip.com/

The above patch has been already reviewed by both Woojung and Simon:
--------------------------------------------------------------------
https://lore.kernel.org/netdev/20240523144056.GO883722@kernel.org/

https://lore.kernel.org/netdev/BL0PR11MB2913CE81AFC08F2D619C3B6CE7F42@BL0PR11MB2913.namprd11.prod.outlook.com/

Hope this clarifies.

Best regards,
Parthiban V