linux-kernel - Re: [PATCH] crypto: ccree: Remove unused struct 'tdes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOtvUMfYbNZ2G7-qkO8PFX5shdZmYvAQa6Uy4XbdvxsmKnDttQ@mail.gmail.com>
Date: Mon, 27 May 2024 15:58:09 +0300
From: Gilad Ben-Yossef <gilad@...yossef.com>
To: linux@...blig.org
Cc: herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: ccree: Remove unused struct 'tdes_keys'

Hi David,

On Sat, May 11, 2024 at 5:52 PM <linux@...blig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> 'tdes_keys' appears unused.
> Remove it.
>

Acked-by: Gilad Ben-Yossef <gilad@...yossef.com>

Thank you for the patch and your patience.

> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>  drivers/crypto/ccree/cc_cipher.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c
> index cd66a580e8b64..3fb667a17bbb1 100644
> --- a/drivers/crypto/ccree/cc_cipher.c
> +++ b/drivers/crypto/ccree/cc_cipher.c
> @@ -261,12 +261,6 @@ static void cc_cipher_exit(struct crypto_tfm *tfm)
>         kfree_sensitive(ctx_p->user.key);
>  }
>
> -struct tdes_keys {
> -       u8      key1[DES_KEY_SIZE];
> -       u8      key2[DES_KEY_SIZE];
> -       u8      key3[DES_KEY_SIZE];
> -};
> -
>  static enum cc_hw_crypto_key cc_slot_to_hw_key(u8 slot_num)
>  {
>         switch (slot_num) {
> --
> 2.45.0
>


-- 
Gilad Ben-Yossef
Chief Coffee Drinker

values of β will give rise to dom!