linux-kernel - Re: [PATCH v2 3/6] mtd: spi-nor: remove .setup() callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mafs0jzjfe66p.fsf@kernel.org>
Date: Mon, 27 May 2024 15:27:10 +0200
From: Pratyush Yadav <pratyush@...nel.org>
To: Michael Walle <mwalle@...nel.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>,  Pratyush Yadav
 <pratyush@...nel.org>,  Miquel Raynal <miquel.raynal@...tlin.com>,
  Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  Ricardo Ribalda <ribalda@...nel.org>,
  linux-kernel@...r.kernel.org,  linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v2 3/6] mtd: spi-nor: remove .setup() callback

Hi,

On Fri, Apr 19 2024, Michael Walle wrote:

> With the removal of the Xilinx flashes, there is no more flash driver
> using that hook. The original intention was to let the driver configure
> special requirements like page size an opcodes.  This is already
> possible by other means and it is unlikely a flash will overwrite the
> (more or less complex) setup function.

Just for comparison, I checked if U-Boot does anything with the setup
hook that we might also need. It looks like it mostly uses it for
handling non-uniform erases on Spansion flashes, since U-Boot doesn't
have proper support for them. This shouldn't be needed by Linux since it
can already do those erases.

Reviewed-by: Pratyush Yadav <pratyush@...nel.org>

-- 
Regards,
Pratyush Yadav