linux-kernel - Re: [PATCH] w1: Fix number of bytes in error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <C3C8C8AE-C5F8-45CE-8319-0985A78DA91F@toblux.com>
Date: Mon, 27 May 2024 15:29:43 +0200
From: Thorsten Blum <thorsten.blum@...lux.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] w1: Fix number of bytes in error message

On 27. May 2024, at 13:51, Krzysztof Kozlowski <krzk@...nel.org> wrote:
> On 13/05/2024 17:43, Thorsten Blum wrote:
>> Fix the number of bytes that failed to be allocated for a new w1 device.
>> 
>> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
>> ---
>> drivers/w1/w1_int.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/w1/w1_int.c b/drivers/w1/w1_int.c
>> index 3a71c5eb2f83..677e7167806c 100644
>> --- a/drivers/w1/w1_int.c
>> +++ b/drivers/w1/w1_int.c
>> @@ -34,7 +34,7 @@ static struct w1_master *w1_alloc_dev(u32 id, int slave_count, int slave_ttl,
>> dev = kzalloc(sizeof(struct w1_master) + sizeof(struct w1_bus_master), GFP_KERNEL);
>> if (!dev) {
>> pr_err("Failed to allocate %zd bytes for new w1 device.\n",
>> - sizeof(struct w1_master));
>> + sizeof(struct w1_master) + sizeof(struct w1_bus_master));
> 
> No, instead error message should be dropped. Core handles printing
> memory allocation failures.

Ok, I'll submit a v2 shortly.