linux-kernel - Re: [PATCH] selftests/mm: hugetlb_madv_vs_map: Avoid test skipping by querying hugepage size at runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f2da186-be75-44de-bc3a-e7f6d0e23498@redhat.com>
Date: Mon, 27 May 2024 15:39:29 +0200
From: David Hildenbrand <dhildenb@...hat.com>
To: Dev Jain <dev.jain@....com>, akpm@...ux-foundation.org, shuah@...nel.org
Cc: linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Anshuman.Khandual@....com
Subject: Re: [PATCH] selftests/mm: hugetlb_madv_vs_map: Avoid test skipping by
 querying hugepage size at runtime



Am 09.05.24 um 11:54 schrieb Dev Jain:
> Currently, the size used in mmap() is statically defined, leading to
> skipping of the test on a hugepage size other than 2 MB, since munmap()
> won't free the hugepage for a size greater than 2 MB. Hence, query the
> size at runtime.
> 
> Also, there is no reason why a hugepage allocation should fail, since we
> are using a simple mmap() using MAP_HUGETLB; hence, instead of skipping
> the test, make it fail.
>   
> Signed-off-by: Dev Jain <dev.jain@....com>
> ---


Likely it would make sense to rewrite that test to try with all available 
hugetlb sizes (like cow.c does).

Acked-by: David Hildenbrand <david@...hat.com>


-- 
Thanks,

David / dhildenb