linux-kernel - [PATCH wireless 0/3] wifi: wilc1000: revert SRCU to RCU conversion series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Tue, 28 May 2024 16:20:27 +0200
From: Alexis Lothoré <alexis.lothore@...tlin.com>
To: linux-wireless@...r.kernel.org
Cc: Ajay Singh <ajay.kathat@...rochip.com>, 
 Claudiu Beznea <claudiu.beznea@...on.dev>, Kalle Valo <kvalo@...nel.org>, 
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
 Dan Carpenter <dan.carpenter@...aro.org>, linux-kernel@...r.kernel.org, 
 Alexis Lothoré <alexis.lothore@...tlin.com>
Subject: [PATCH wireless 0/3] wifi: wilc1000: revert SRCU to RCU conversion
 series

This series is a follow-up to the static analyzer warnings raised by Dan
Carpenter ([1]), and the agreement to proceed with a revert ([2]) due to the
difficulties involved in fixing the remaining issues.

The initial series aimed to simplify the driver by switching it to
classical RCU, since there was no evidence of SRCU usage legitimity in it.
The warnings raised after the merge are likely hinting at some technical
constraints which eventually led to SRCU usage, so put it back.
Additionally, the series adds some comments to document SRCU usage.

Unfortunately the faulty series reached a tagged release, so this revert
series targets the wireless tree (ie not the wireless-next).

[1] https://lore.kernel.org/linux-wireless/3b46ec7c-baee-49fd-b760-3bc12fb12eaf@moroto.mountain/
[2] https://lore.kernel.org/linux-wireless/878qzu8e4k.fsf@kernel.org/

---
Alexis Lothoré (3):
      Revert "wifi: wilc1000: convert list management to RCU"
      Revert "wifi: wilc1000: set atomic flag on kmemdup in srcu critical section"
      wifi: wilc1000: document SRCU usage instead of SRCU

 drivers/net/wireless/microchip/wilc1000/cfg80211.c | 41 ++++++++++++---------
 drivers/net/wireless/microchip/wilc1000/hif.c      | 17 +++++----
 drivers/net/wireless/microchip/wilc1000/netdev.c   | 43 +++++++++++++---------
 drivers/net/wireless/microchip/wilc1000/netdev.h   | 12 +++++-
 drivers/net/wireless/microchip/wilc1000/wlan.c     |  5 ++-
 5 files changed, 72 insertions(+), 46 deletions(-)
---
base-commit: 7e81b62cfb9abdd8177606f7c79a0585503bd7ae
change-id: 20240528-wilc_revert_srcu_to_rcu-57c6a9138345

Best regards,
-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com