linux-kernel - Re: [PATCH v2] hwmon: (max6639) : Update hwmon init using info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202405282222.1d8A5KLv-lkp@intel.com>
Date: Tue, 28 May 2024 22:28:18 +0800
From: kernel test robot <lkp@...el.com>
To: Naresh Solanki <naresh.solanki@...ements.com>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>
Cc: oe-kbuild-all@...ts.linux.dev,
	Naresh Solanki <naresh.solanki@...ements.com>,
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hwmon: (max6639) : Update hwmon init using info

Hi Naresh,

kernel test robot noticed the following build errors:

[auto build test ERROR on 5fbf8734fb36cf67339f599f0e51747a6aff690c]

url:    https://github.com/intel-lab-lkp/linux/commits/Naresh-Solanki/hwmon-max6639-Update-hwmon-init-using-info/20240528-172245
base:   5fbf8734fb36cf67339f599f0e51747a6aff690c
patch link:    https://lore.kernel.org/r/20240528091808.863702-1-naresh.solanki%409elements.com
patch subject: [PATCH v2] hwmon: (max6639) : Update hwmon init using info
config: i386-randconfig-015-20240528 (https://download.01.org/0day-ci/archive/20240528/202405282222.1d8A5KLv-lkp@intel.com/config)
compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240528/202405282222.1d8A5KLv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405282222.1d8A5KLv-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/hwmon/max6639.c: In function 'max6639_read_pwm':
>> drivers/hwmon/max6639.c:291:3: error: a label can only be part of a statement and a declaration is not a statement
     291 |   u8 x;
         |   ^~
   drivers/hwmon/max6639.c: In function 'max6639_write_pwm':
   drivers/hwmon/max6639.c:328:3: error: a label can only be part of a statement and a declaration is not a statement
     328 |   u8 x;
         |   ^~


vim +291 drivers/hwmon/max6639.c

   275	
   276	static int max6639_read_pwm(struct device *dev, u32 attr, int channel,
   277				    long *pwm_val)
   278	{
   279		struct max6639_data *data = dev_get_drvdata(dev);
   280		unsigned int val, res;
   281	
   282		if (IS_ERR(data))
   283			return PTR_ERR(data);
   284	
   285		switch (attr) {
   286		case hwmon_pwm_input:
   287			res = regmap_read(data->regmap, MAX6639_REG_TARGTDUTY(channel), &val);
   288			*pwm_val = val * 255 / 120;
   289			return 0;
   290		case hwmon_pwm_freq:
 > 291			u8 x;
   292	
   293			res = regmap_read(data->regmap, MAX6639_REG_FAN_CONFIG3(channel), &val);
   294			if (res < 0)
   295				return res;
   296			x = val & MAX6639_FAN_CONFIG3_FREQ_MASK;
   297	
   298			res = regmap_read(data->regmap, MAX6639_REG_GCONFIG, &val);
   299			if (res < 0)
   300				return res;
   301	
   302			if (val & MAX6639_GCONFIG_PWM_FREQ_HI)
   303				x |= 0x4;
   304			x &= 0x7;
   305			*pwm_val = freq_table[x];
   306			return res;
   307		default:
   308			return -EOPNOTSUPP;
   309		}
   310	}
   311	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki