linux-kernel - Re: [PATCH RESEND 1/3] drm/panel: sitronix-st7789v: fix timing for jt240mhqs_hwt_ek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d10e14ce-b65f-4dbd-8686-bf8c1796ba06@quicinc.com>
Date: Tue, 28 May 2024 10:36:20 -0700
From: Jessica Zhang <quic_jesszhan@...cinc.com>
To: Gerald Loacker <gerald.loacker@...fvision.net>,
        Neil Armstrong
	<neil.armstrong@...aro.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard
	<mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie
	<airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>
CC: <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND 1/3] drm/panel: sitronix-st7789v: fix timing for
 jt240mhqs_hwt_ek_e3 panel



On 5/28/2024 1:32 AM, Gerald Loacker wrote:
> Flickering was observed when using partial mode. Moving the vsync to the
> same position as used by the default sitronix-st7789v timing resolves this
> issue.
> 
> Signed-off-by: Gerald Loacker <gerald.loacker@...fvision.net>

Hi Gerald,

Just wondering, are these new timing values taken from the panel specs? 
If the timing in the original patch was wrong, maybe we need a fixes tag.

Acked-by: Jessica Zhang <quic_jesszhan@...cinc.com>

Thanks,

Jessica Zhang

> ---
>   drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> index 88e80fe98112..32e5c0348038 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> @@ -286,9 +286,9 @@ static const struct drm_display_mode jt240mhqs_hwt_ek_e3_mode = {
>   	.hsync_end = 240 + 28 + 10,
>   	.htotal = 240 + 28 + 10 + 10,
>   	.vdisplay = 280,
> -	.vsync_start = 280 + 8,
> -	.vsync_end = 280 + 8 + 4,
> -	.vtotal = 280 + 8 + 4 + 4,
> +	.vsync_start = 280 + 48,
> +	.vsync_end = 280 + 48 + 4,
> +	.vtotal = 280 + 48 + 4 + 4,
>   	.width_mm = 43,
>   	.height_mm = 37,
>   	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> 
> -- 
> 2.37.2
>